Use named slots to have advanced ha-card headers#3127
Merged
Conversation
balloob
reviewed
Apr 27, 2019
Contributor
Author
|
A bit of background to the latest commit. Previously, the opacity of the header text was set to .87. As it turns out, for pure black text on white background, this corresponds to #212121 which is the default I also added some (currently unused) theming variables. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the discussions for #2701 I mentioned I tried to use named slots in ha-card for "advanced" headers, like the entities-card one with the toggle.
I finally came up with a way to make it work.
This avoids code duplication w.r.t. things like header font size and stuff.