Make Hass.io menu toggle button work in pre and post 90 release#2959
Merged
Conversation
ghost
assigned
balloob
commented
Mar 18, 2019
| @@ -1,41 +0,0 @@ | |||
| import { html } from "@polymer/polymer/lib/utils/html-tag"; | |||
Member
Author
There was a problem hiding this comment.
Deleted this file as it was not being used anymore.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2930 we simplified
<ha-menu-button>to just firehass-toggle-menuinstead of differentiating betweenhass-open-menuandhass-close-menu. Great clean up, however also breaks the contract between custom panels that work in iframes and Home Assistant, of which one the most popular is Hass.io.The Hass.io supervisor is not tight to a Home Assistant release. This means that newer builds of the supervisor and its new UI can run on old versions of Home Assistant. By breaking the API, it means that if the supervisor and its new UI would run on an old version of Home Assistant, the menu button won't work. Especially annoying if you are on mobile and are unable to dock the sidebar.
So to work around this, we're going to have the Hass.io panel translate
hass-toggle-menuevents into the appropriatehass-open-menu/hass-close-menuevents to keep compatibility with older Home Assistant versions.Lesson learned: don't mess with our custom panel API!