Skip to content

Bail out early when no stream component#2927

Merged
balloob merged 1 commit into
devfrom
bail-out-early-stream
Mar 13, 2019
Merged

Bail out early when no stream component#2927
balloob merged 1 commit into
devfrom
bail-out-early-stream

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Mar 13, 2019

Don't even try to test for HLS support if the stream component is not loaded.

@ghost ghost assigned balloob Mar 13, 2019
@ghost ghost added the in progress label Mar 13, 2019
return;
}

if (!this.hass!.config.components.includes("stream")) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should add a similar check to the shopping-list card

@balloob balloob merged commit 92e6c5a into dev Mar 13, 2019
@ghost ghost removed the in progress label Mar 13, 2019
@delete-merged-branch delete-merged-branch Bot deleted the bail-out-early-stream branch March 13, 2019 20:33
@balloob balloob mentioned this pull request Mar 15, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants