Skip to content

Cleanups#2658

Merged
balloob merged 8 commits into
devfrom
cleanups
Feb 2, 2019
Merged

Cleanups#2658
balloob merged 8 commits into
devfrom
cleanups

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 2, 2019

Just some cleanups around app startup.

Also making LitElement's css available on the prototype. (CC @thomasloven @bramkragten )

@ghost ghost assigned balloob Feb 2, 2019
@ghost ghost added the in progress label Feb 2, 2019
@iantrich
Copy link
Copy Markdown
Member

iantrich commented Feb 2, 2019

I'm not too familiar with exposing things on prototype, but can anything be exposed in this way? e.g. could we expose the navigate functionality to custom cards?

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Feb 2, 2019

@iantrich for navigation, just use <a href="/lovelace/something">BLA</a>, our navigation code will intercept it

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Feb 2, 2019

I don't like to expose internals, but as people were extending our elements, without the proper css and html there is no possibility to create your own templates.

@balloob balloob merged commit 79183bb into dev Feb 2, 2019
@ghost ghost removed the in progress label Feb 2, 2019
@delete-merged-branch delete-merged-branch Bot deleted the cleanups branch February 2, 2019 21:23
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants