Skip to content

Hash translation files#2652

Merged
balloob merged 2 commits into
devfrom
hash-translation-files
Feb 2, 2019
Merged

Hash translation files#2652
balloob merged 2 commits into
devfrom
hash-translation-files

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 2, 2019

Store the translation files with hashes in the filename. This were the last files that was still using the fake fingerprinting that the backed had integrated. We can drop that now.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Feb 2, 2019

@armills do you remember why we didn't do this from the beginning?

@emlove
Copy link
Copy Markdown
Contributor

emlove commented Feb 2, 2019

I think we were just matching the build pipeline we had at the time, where we used the backend fingerprinting for a lot more. I don't think there's any reason we can't use gulp to hash these.

@balloob balloob merged commit 4921686 into dev Feb 2, 2019
@ghost ghost removed the in progress label Feb 2, 2019
@delete-merged-branch delete-merged-branch Bot deleted the hash-translation-files branch February 2, 2019 17:42
@balloob balloob mentioned this pull request Feb 2, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants