Skip to content

Marked Arabic as RTL + added a bunch of lovelace menu entries to label files#2650

Merged
balloob merged 2 commits into
home-assistant:devfrom
yosilevy:Translation-updates
Feb 2, 2019
Merged

Marked Arabic as RTL + added a bunch of lovelace menu entries to label files#2650
balloob merged 2 commits into
home-assistant:devfrom
yosilevy:Translation-updates

Conversation

@yosilevy
Copy link
Copy Markdown
Contributor

@yosilevy yosilevy commented Feb 1, 2019

No description provided.

@ghost ghost added the in progress label Feb 1, 2019
Comment thread src/panels/lovelace/hui-root.ts Outdated
<paper-item @click="${this._handleHelp}">Help</paper-item>
<paper-item @click="${this._handleHelp}"
>${this.hass!.localize(
"ui.panel.lovelace.editor.help"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not part of the editor but part of the menu.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was because the configure_ui key was already in the editor so I wanted to keep things as is. Will refactor it all as per our conversation.

@balloob balloob merged commit a5bdf09 into home-assistant:dev Feb 2, 2019
@ghost ghost removed the in progress label Feb 2, 2019
@balloob balloob mentioned this pull request Feb 2, 2019
@yosilevy yosilevy deleted the Translation-updates branch February 3, 2019 07:06
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants