Marked Arabic as RTL + added a bunch of lovelace menu entries to label files#2650
Merged
Merged
Conversation
balloob
reviewed
Feb 1, 2019
| <paper-item @click="${this._handleHelp}">Help</paper-item> | ||
| <paper-item @click="${this._handleHelp}" | ||
| >${this.hass!.localize( | ||
| "ui.panel.lovelace.editor.help" |
Member
There was a problem hiding this comment.
This is not part of the editor but part of the menu.
Contributor
Author
There was a problem hiding this comment.
This was because the configure_ui key was already in the editor so I wanted to keep things as is. Will refactor it all as per our conversation.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.