Skip to content

Put geo_events on a map instead of an entities card.#2489

Merged
balloob merged 1 commit into
devfrom
lovelace-autogen-geo_event
Jan 16, 2019
Merged

Put geo_events on a map instead of an entities card.#2489
balloob merged 1 commit into
devfrom
lovelace-autogen-geo_event

Conversation

@thomasloven
Copy link
Copy Markdown
Contributor

... With the default solution, geo_events are added to a static list - i.e. it doesn't update as new geo_events are added or they are resolved.

This was the best way I could come up with to fix things. Had to add a new magic value to the geo_event_sources list for the map card (needs documentation).

Unfortunately the distance to the event is lost.

Before:
spurious entities

After:
map events

@thomasloven thomasloven force-pushed the lovelace-autogen-geo_event branch from ce2c401 to 8c34b39 Compare January 16, 2019 13:06
@thomasloven
Copy link
Copy Markdown
Contributor Author

Zones and location trackers could also be put on a map, perhaps?

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 16, 2019

Nice!

I think that we could consider adding the device trackers to it too. Or maybe that should be a separate one? I think that we can wait with that because we currently already have them as a badge. I hope that we can get to implement our "Person" implementation soon, which should be preferred over device trackers.

@balloob balloob merged commit f7a67af into dev Jan 16, 2019
@ghost ghost removed the in progress label Jan 16, 2019
@delete-merged-branch delete-merged-branch Bot deleted the lovelace-autogen-geo_event branch January 16, 2019 22:01
@thomasloven
Copy link
Copy Markdown
Contributor Author

Yeah. This was kind of urgent because it looked ugly by default (is there anything using geo_location?) - device trackers aren't.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 16, 2019

geo location is a different category than device trackers. Geo location is for feeds that have time-based location events, like fires, storms, etc. Things that come and go.

@balloob balloob mentioned this pull request Jan 17, 2019
@thomasloven
Copy link
Copy Markdown
Contributor Author

Yes. My question is if there are any components that actually use them (besides demo).

... rtfm, Thomas. The docs tells me that yes, there are.

thomasloven added a commit to home-assistant/home-assistant.io that referenced this pull request Feb 13, 2019
frenck pushed a commit to home-assistant/home-assistant.io that referenced this pull request Feb 13, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants