Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce min_columns of Tile Card to 3 to improve look #23661

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

watercrossing
Copy link

Proposed change

The tile card has a minimum column width of 6. For some entities this leaves a lot of empty space on the tile card, which looks odd. A default width of 6 is sensible, but the user should have the freedom to make it less wide if desired. In the screenshot below, the left Coffee input_datetime has a default width of 6, the right Coffee input_datetime a width 4, and the bottom Coffee input_datetime a width 3.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

type: tile
entity: input_datetime.coffee_machine_start_time
name: Coffee
grid_options:
  columns: 4
  rows: 1
icon: mdi:coffee-maker

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @watercrossing

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft January 9, 2025 17:23
@home-assistant
Copy link

home-assistant bot commented Jan 9, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant