Fixes the rendering of the weather card

[alex3305]

This was reported in #2294 and caused by an undefined variable. This variable is removed with this commit.

[zsarnett]

We do not need to remove this variable. We need to correctly pass it to the weather legacy card

[alex3305]

@zsarnett Any suggestion on where that is done? Because I would like to ammend this PR if possible. Otherwise it can be closed.

[zsarnett]

If you look at the weather card in the Lovelace Cards directory it uses legacy wrapper. The legacy wrapper need to correctly pass config or we need to up the legacy weather card to use the config it's given and set this.config correctly. I havent drilled into it yet. But that's the basis

[zsarnett]

Also this is an issue for the plant card as well. We can fix both as it should be the same issue

[alex3305]

I've ammended my commit with the same property as is defined by the plant card. I didn't see your new message unfortunately. So I am unsure if this is the right approach.

[zsarnett]

Have you tested this approach?

[alex3305]

Yes, I've tested this in my local dev environment with a pip3 install and --skip-pip when starting up Home Assistant and the card rendered again. I've also tested it with the Home Assistant provided frontend and there the error still occurs.

[zsarnett]

And can your try setting a name variable

[alex3305]

@zsarnett I'm unsure what you mean with:

And can your try setting a name variable

[zsarnett]

name: test in the love lace config for the card

[zsarnett]

Or is this an issue for states UI?

[alex3305]

This is an issue for the states-ui. I'm also unable to open lovelace on my dev environment, because it's triggering home-assistant/core#18193.

Edit: Appearently it loaded after some retries. No specific lovelace errors given, but also no name displayed in either weather cards (states and lovelace).

[balloob]

This won't fix it … this.config is still not defined just because you define it as a property. We need to add a guard to it.