Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace add_zone with create_zone in ha-config-zone.ts #23041

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

NoRi2909
Copy link
Contributor

In #22942 we changed ui.panel.config.zone.create_zone to use the correct "Create zone" again.

The ui.panel.config.zone.add_zone string was left untouched and as it turns out this is the one the action button still uses:
image

This PR fixes this by making the button use the correct and consistent "Create zone" string, too.

Proposed change

Replace reference to ui.panel.config.zone.add_zone with ui.panel.config.zone.create_zone

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The action button is the only inconsistent item here now.
@NoRi2909
Copy link
Contributor Author

If I checked this correctly, ui.panel.config.zone.add_zone is now orphaned with this change and could also be removed.

@MindFreeze
Copy link
Contributor

If I checked this correctly, ui.panel.config.zone.add_zone is now orphaned with this change and could also be removed.

Yes, please remove ui.panel.config.zone.add_zone

@NoRi2909
Copy link
Contributor Author

OK, I've added the second commit.

@MindFreeze MindFreeze merged commit de87aee into home-assistant:dev Nov 28, 2024
15 checks passed
@MindFreeze
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants