Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ha-alert-narrow-action #22956

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Ha-alert-narrow-action #22956

merged 2 commits into from
Nov 22, 2024

Conversation

wendevlin
Copy link
Contributor

@wendevlin wendevlin commented Nov 22, 2024

Proposed change

  • add narrow bool prop to ha-alert
    • set content flex direction to column, to have buttons at a new line
    • based on design: open figma
  • Use this narrow option in ha-scene-editor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze merged commit 528fcec into dev Nov 22, 2024
16 checks passed
@MindFreeze MindFreeze deleted the ha-alert-narrow-action branch November 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants