exporation: Use indexes for editing#2233
Merged
bramkragten merged 1 commit intoedit-storagefrom Dec 9, 2018
Merged
Conversation
ghost
assigned
balloob
force-pushed
the
index-based-config
branch
from
8b09e56 to
b6b2869
Compare
Member
|
Was this supposed to be merged? |
Member
|
I merged it in my PR, not in dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an exploration to convert refering to cards being edited by an index path
[viewIndex, cardIndex]instead of cardConfig, as that fits better with doing mutation on frontend.Work done on top of #2228
Not for merging.