Skip to content

Fix long press in FF#2226

Merged
balloob merged 2 commits intodevfrom
fix-long-press-ff
Dec 9, 2018
Merged

Fix long press in FF#2226
balloob merged 2 commits intodevfrom
fix-long-press-ff

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Dec 7, 2018

Test that TouchEvent exists before referring to it.

Fixes #2218

@thomasloven
Copy link
Copy Markdown
Contributor

thomasloven commented Dec 7, 2018

Wouldn't it be better to just check if ev.type is touchend or touchcancel?

I don't know what FF has instead of TouchEvent, but with this we risk missing it.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Dec 8, 2018

Sounds good.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Dec 8, 2018

Done.

@balloob balloob merged commit 2a23487 into dev Dec 9, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-long-press-ff branch December 9, 2018 09:09
@ghost ghost removed the in progress label Dec 9, 2018
@balloob balloob mentioned this pull request Dec 10, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.84.0b1 - LL TouchEvent is not defined

3 participants