Skip to content

Fix edit view and layout#2213

Merged
bramkragten merged 2 commits intodevfrom
fix-edits
Dec 7, 2018
Merged

Fix edit view and layout#2213
bramkragten merged 2 commits intodevfrom
fix-edits

Conversation

@bramkragten
Copy link
Copy Markdown
Member

No description provided.

@ghost ghost assigned bramkragten Dec 7, 2018
@ghost ghost added the in progress label Dec 7, 2018
@bramkragten bramkragten added this to the 0.84 milestone Dec 7, 2018
paper-button.warning:not([disabled]) {
color: var(--google-red-500);
paper-icon-button.warning:not([disabled]) {
float: right;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure this is the default text color?

!this.add
? html`
<paper-icon-button
class="warning"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be red.

}</paper-button
>
<paper-icon-button
class="warning"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be red

@bramkragten bramkragten merged commit 48220b6 into dev Dec 7, 2018
@ghost ghost removed the in progress label Dec 7, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-edits branch December 7, 2018 12:20
@balloob balloob mentioned this pull request Dec 10, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants