Skip to content

Fixes Color not being overwritten by themes for cards #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
Dec 5, 2018
Merged

Fixes Color not being overwritten by themes for cards #2179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/ha-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class HaCard extends PolymerElement {
border-radius: 2px;
transition: all 0.3s ease-out;
background-color: var(--paper-card-background-color, white);
color: var(--primary-text-color);
Copy link
Copy Markdown
Member

@balloob balloob Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making a change like this to a web component that we use throughout the whole Home Assistant and Hass.io UI seems a little wild. Do we really know that we're not messing with anything here?

Copy link
Copy Markdown
Contributor Author

@zsarnett zsarnett Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the color css was set back on panel element and therefore taking the value of primary text color back at that Dom. This just allows it to be changed in the card Dom. If the variable is not overwritten itshould still assume the primary text color set at panel element

Copy link
Copy Markdown
Member

@balloob balloob Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do realize that this is not a Lovelace specific element?

Copy link
Copy Markdown
Contributor Author

@zsarnett zsarnett Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. But the logic is still the same. The variable will trickle down and only if overwritten will it be changed. Currently it does not work as expected because color is set so high in the Dom tree

}
.header {
@apply --paper-font-headline;
Expand Down