Merged
Conversation
ghost
assigned
|
Please also add strings to translation to we can start working on translating. |
balloob
reviewed
Dec 3, 2018
balloob
reviewed
Dec 3, 2018
balloob
reviewed
Dec 3, 2018
balloob
reviewed
Dec 3, 2018
balloob
reviewed
Dec 3, 2018
bramkragten
commented
Dec 4, 2018
| showEditViewDialog(this, { | ||
| add: true, | ||
| reloadLovelace: () => { | ||
| this.fire("config-refresh"); |
Member
Author
There was a problem hiding this comment.
I would like to do this._selectView(this.config.views.length - 1); to go to the newly created view, but I don't know when the config is loaded... Any way to tell? this._curView = this.config.views.length works but uhh 😬
Member
There was a problem hiding this comment.
could you add event detail to say "refresh and pick view" ?
Member
Author
|
The translations are a breaking change :-( |
balloob
reviewed
Dec 4, 2018
| .viewConfig="${this._params.viewConfig}" | ||
| .add="${this._params.add}" | ||
| @reload-lovelace="${this._params.reloadLovelace}" | ||
| @cancel-edit-view="${this._cancel}" |
Member
There was a problem hiding this comment.
Do you have to remove the registration of these events with typescript?
Member
Author
There was a problem hiding this comment.
I removed cancel-edit-view the other one is still used
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1961 Closes: #1962 Closes: #1963