Skip to content

Handle mouse events on touchscreens. Fix #2085#2170

Merged
balloob merged 6 commits intodevfrom
fix-longpress-touchscreen-click
Dec 5, 2018
Merged

Handle mouse events on touchscreens. Fix #2085#2170
balloob merged 6 commits intodevfrom
fix-longpress-touchscreen-click

Conversation

@thomasloven
Copy link
Copy Markdown
Contributor

@thomasloven thomasloven commented Dec 3, 2018

I think this does it.

Before merging I would want someone to test on:

  • Chrome for Android
  • Windows 10 pc with touchscreen (mouse)
  • Windows 10 pc with touchscreen (touch)
  • Safari on iphone

@ghost ghost assigned thomasloven Dec 3, 2018
@ghost ghost added the in progress label Dec 3, 2018
@zsarnett
Copy link
Copy Markdown
Contributor

zsarnett commented Dec 3, 2018

Chrome on Android ✔️

@iantrich
Copy link
Copy Markdown
Member

iantrich commented Dec 3, 2018

Not working for Windows 10 with touchscreen for mouse events. Touch events are working still.

@zsarnett
Copy link
Copy Markdown
Contributor

zsarnett commented Dec 3, 2018

long-press-directive.ts:85 [Intervention] Ignored attempt to cancel a touchstart event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.
clickStart @ long-press-directive.ts:85
long-press-directive.ts:107 [Intervention] Ignored attempt to cancel a touchend event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.
clickEnd @ long-press-directive.ts:107

RIP ❌ Android Chrome

@thomasloven
Copy link
Copy Markdown
Contributor Author

thomasloven commented Dec 4, 2018

Trying again. Resetting the test list.

This may be a bit.. rickety...

@iantrich
Copy link
Copy Markdown
Member

iantrich commented Dec 4, 2018

No on Win10/Touch for Mouse, Touch still works

I lied. This is indeed working for me now! 🎉

@zsarnett
Copy link
Copy Markdown
Contributor

zsarnett commented Dec 4, 2018

Not working on Android Chrome

@thomasloven
Copy link
Copy Markdown
Contributor Author

Let's try something else. New round!

@iantrich
Copy link
Copy Markdown
Member

iantrich commented Dec 4, 2018

Works on Win10 with touch and mouse

@thomasloven thomasloven force-pushed the fix-longpress-touchscreen-click branch from 8c0c169 to 0adc821 Compare December 5, 2018 19:47
@balloob balloob merged commit 9711068 into dev Dec 5, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-longpress-touchscreen-click branch December 5, 2018 21:05
@ghost ghost removed the in progress label Dec 5, 2018
@balloob balloob mentioned this pull request Dec 5, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants