Extract Supported features into own funciton#2151
Merged
balloob merged 4 commits intohome-assistant:devfrom Nov 30, 2018
Merged
Extract Supported features into own funciton#2151balloob merged 4 commits intohome-assistant:devfrom
balloob merged 4 commits intohome-assistant:devfrom
Conversation
ghost
assigned
balloob
reviewed
Nov 30, 2018
| if (domain === "climate") { | ||
| // tslint:disable-next-line | ||
| return (stateObj.attributes.supported_features! & 4096) !== 0; | ||
| return supportsFeature(stateObj, 4096); |
Member
There was a problem hiding this comment.
4096 should be stored in a constant under src/data/climate.ts
Member
Author
There was a problem hiding this comment.
Yeah. Debated doing so but thought best to do later.
balloob
reviewed
Nov 30, 2018
| supportsTemperature(stateObj) { | ||
| return ( | ||
| (stateObj.attributes.supported_features & 1) !== 0 && | ||
| supportsFeature(stateObj, 1) && |
Member
There was a problem hiding this comment.
constants? (or maybe out of scope for this PR)
balloob
approved these changes
Nov 30, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.