Add own types + add config validation to glances#2150
Merged
Conversation
ghost
assigned
zsarnett
reviewed
Nov 29, 2018
zsarnett
reviewed
Nov 30, 2018
balloob
reviewed
Nov 30, 2018
| @@ -24,11 +24,11 @@ import "../../../../components/ha-icon"; | |||
|
|
|||
| const entitiesConfigStruct = struct.union([ | |||
Member
There was a problem hiding this comment.
Do we need this union? I can imagine it will be a lot easier for us to just convert it to an object before validating it ?
Member
Author
There was a problem hiding this comment.
Don't know if that is easier, would rather validate before processing it. Otherwise, we will still have to manual check to see if entities is present and if it is an array etc...
If we can just add this to the struct, I think it is easier this way. But until the editor supports all the functions we have to create custom ones :-(
balloob
approved these changes
Nov 30, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.