Add supported_features to cover component#215
Merged
Conversation
|
@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @turbokongen, @balloob and @borigas to be potential reviewers. |
2 tasks
Member
|
This is awesome 🐬 . I think that sometime in the future we should consider creating a new repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polymer PR for home-assistant/core#6082
I used the same structure as
src/util/media-player-model.html. If this PR oversteps its bounds I can roll some of these changes back, but having an object responsible for representing the entity and its functions seems like the right way to go.Also, I used the invisible attribute instead of polymer's hidden, so that the open/close arrows line up with each other, instead of collapsing to use the whitespace.