Conversation
ghost
assigned
iantrich
reviewed
Nov 28, 2018
iantrich
reviewed
Nov 28, 2018
iantrich
reviewed
Nov 28, 2018
iantrich
reviewed
Nov 28, 2018
iantrich
reviewed
Nov 28, 2018
iantrich
reviewed
Nov 28, 2018
iantrich
reviewed
Nov 28, 2018
balloob
reviewed
Nov 29, 2018
balloob
reviewed
Nov 29, 2018
balloob
reviewed
Nov 29, 2018
balloob
reviewed
Nov 29, 2018
zsarnett
added
the
Breaking Change
Contributor
Author
|
I have a commit waiting to reset the date after pulling the history... I forgot to push. |
balloob
reviewed
Nov 30, 2018
balloob
reviewed
Nov 30, 2018
balloob
reviewed
Nov 30, 2018
balloob
previously approved these changes
Nov 30, 2018
zsarnett
dismissed
balloob’s stale review
I would like this to be reviewed again as many things have changed.
Contributor
Author
|
NOt sure how to use the function Balloob was describing in Discord from the history element. Something to with Cache I believe. |
bramkragten
approved these changes
Nov 30, 2018
Member
bramkragten
left a comment
bramkragten
left a comment
There was a problem hiding this comment.
Adding caching can be done in a new pr, it didn't have it before right?
| viewBox="0 0 500 100" | ||
| ></svg> | ||
| ` | ||
| this._config.graph === "line" |
Member
There was a problem hiding this comment.
Break it up before the return so readabilty improves.
let content;
if (this._config.graph === "line") {
content = html`...`;
} else {
content = html`...`;
}
Contributor
Author
There was a problem hiding this comment.
Sounds good. Will update and merge thanks @bramkragten
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a beast of a Card. Im sure I messed something up...