Display alert entity row as a toggle#2138
Merged
balloob merged 2 commits intohome-assistant:devfrom Nov 29, 2018
pprazzi:patch-1
Merged
Display alert entity row as a toggle#2138balloob merged 2 commits intohome-assistant:devfrom pprazzi:patch-1
balloob merged 2 commits intohome-assistant:devfrom
pprazzi:patch-1
Conversation
In the default UI alerts where displayed as toggles, this change makes this also the default behaviour in Lovelace
Contributor
ghost
added
the
iantrich
reviewed
Nov 28, 2018
| ]); | ||
| const DOMAIN_TO_ELEMENT_TYPE = { | ||
| automation: "toggle", | ||
| alert: "toggle", |
Member
|
I want to test how this behaves before approving as you noted in the Discord chat this is untested. |
iantrich
changed the title
Member
|
I did verify that this is working as intended on my dev environment. Going to leave it till tomorrow to see if anyone objects to this way of representing the alert row |
iantrich
approved these changes
Nov 29, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the default UI alerts where displayed as toggles, this change makes this also the default behaviour in Lovelace