Conversation
ghost
assigned
balloob
reviewed
Nov 27, 2018
src/cards/ha-weather-card.js
Outdated
| } | ||
|
|
||
| computeName(stateObj) { | ||
| return this.config.name || stateObj.attributes.friendly_name; |
Member
There was a problem hiding this comment.
We shouldn't use stateObj.attributes.friendly_name but instead use https://github.com/home-assistant/home-assistant-polymer/blob/dev/src/common/entity/compute_state_name.ts
Contributor
Author
There was a problem hiding this comment.
Okay. So I thought about doing that but figured I would keep it the same and then I forgot to mention that in my description...
Member
There was a problem hiding this comment.
this.config is not set on legacy UI, so can't just be referenced for any element in src/cards
balloob
approved these changes
Nov 27, 2018
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.