Skip to content

Removes Height, Light Width and Line Color from Sensor #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 3 commits into from
Nov 27, 2018
Merged

Removes Height, Light Width and Line Color from Sensor #2122

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfd051e
Sensor fix
zsarnett Nov 27, 2018
3534e21
SVG prettified - Use Accent Color only - Dont Calc height
zsarnett Nov 27, 2018
c9f9348
Prettier
zsarnett Nov 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions src/panels/lovelace/cards/hui-sensor-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,11 @@ class HuiSensorCard extends EventsMixin(LitElement) {
const cardConfig = {
detail: 1,
icon: false,
height: 100,
hours_to_show: 24,
line_color: "var(--accent-color)",
line_width: 5,
...config,
};
cardConfig.hours_to_show = Number(cardConfig.hours_to_show);
cardConfig.height = Number(cardConfig.height);
cardConfig.line_width = Number(cardConfig.line_width);
cardConfig.detail =
cardConfig.detail === 1 || cardConfig.detail === 2
? cardConfig.detail
Expand All @@ -64,7 +60,7 @@ class HuiSensorCard extends EventsMixin(LitElement) {
return change;
}

render({ _config, _entity, _line } = this) {
render({ _entity, _line } = this) {
return html`
${this._style()}
<ha-card @click="${this._handleClick}">
Expand All @@ -85,11 +81,17 @@ class HuiSensorCard extends EventsMixin(LitElement) {
${
_line
? svg`
<svg width='100%' height='100%' viewBox='0 0 500 ${_config.height}'>
<path d=${_line} fill='none' stroke=${_config.line_color}
stroke-width=${_config.line_width}
stroke-linecap='round' stroke-linejoin='round' />
</svg>`
<svg width="100%" height="100%" viewBox="0 0 500 100">
<path
d="${_line}"
fill="none"
stroke="var(--accent-color)"
stroke-width="5"
stroke-linecap="round"
stroke-linejoin="round"
/>
</svg>
`
: ""
}
</div>
Expand Down Expand Up @@ -144,8 +146,8 @@ class HuiSensorCard extends EventsMixin(LitElement) {

_calcPoints(history, hours, width, detail = 1) {
const coords = [];
const margin = this._config.line_width;
const height = this._config.height - margin * 4;
const margin = 5;
const height = 80;
width -= margin * 2;
let yRatio = (this._max - this._min) / height;
yRatio = yRatio !== 0 ? yRatio : height;
Expand Down