Add html to LitElement.prototype#2120
Merged
balloob merged 1 commit intohome-assistant:devfrom Nov 26, 2018
Merged
Conversation
Contributor
Contributor
|
As much as I'd love to pull a fast one and just sneak-merge this, I would like to hear what @balloob has to say, since I know he doesn't really like putting stuff in the global scope. Also, why only lit-html? Why not LitElement too? Edit: Wait... this won't put anything in the global scope, will it? |
Member
|
What can go wrong 🙈 |
Member
Author
|
@balloob Thanks for the help! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR maps the
htmlfunction formlit-htmltoLitElement.prototype.htmlto be accessible within custom_ui components when overriding existing class implementation.I've added the mapping inside
src/layouts/app/home-assistant.jsfor now, but am happy to move it if there is a better place for it.Example
Fixes: #2107
CC: @balloob