Merged
Conversation
ghost
assigned
bramkragten
commented
Nov 26, 2018
| this.hass!, | ||
| this.cardConfig!, | ||
| () => fireEvent(this, "config-refresh"), | ||
| () => this._editCard() |
Member
Author
There was a problem hiding this comment.
This makes no sense, can better check for an ID before calling delete
Member
There was a problem hiding this comment.
Yep, disable button when no ID and wrap it in a tooltip saying "Card has no ID"
Member
Author
There was a problem hiding this comment.
Or show the migrate dialog, like this._editCard() does?
balloob
reviewed
Nov 26, 2018
balloob
reviewed
Nov 26, 2018
balloob
reviewed
Nov 26, 2018
balloob
reviewed
Nov 26, 2018
bramkragten
force-pushed
the
delete-card
branch
from
39746f3 to
cef0a6f
Compare
balloob
approved these changes
Nov 28, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1957