Convert shopping-list update to WebSockets#2114
Merged
balloob merged 1 commit intohome-assistant:devfrom Nov 26, 2018
Merged
Conversation
ghost
assigned
iantrich
changed the title
balloob
approved these changes
Nov 26, 2018
balloob
reviewed
Nov 26, 2018
| @@ -25,7 +27,9 @@ export const completeItem = ( | |||
| itemId: number, | |||
Member
There was a problem hiding this comment.
I realize now that this is a bit weird, we shouldn't have 2 methods that call same function. The functions in data/* should be modeled after the APIs, not how it's used in our web components.
We should merge these two methods, like this: https://github.com/home-assistant/home-assistant-polymer/blob/8ad5280501e3e5b91a48f740df39956bb3c11616/src/panels/config/cloud/data.ts#L7-L18
(Yes, this method should be under data/cloud.ts which I'll fix in a future PR)
Member
Author
There was a problem hiding this comment.
I’ll do so in my next pr. Thanks!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by home-assistant/core#18713