Conversation
ghost
assigned
balloob
commented
Nov 23, 2018
|
|
||
| states.forEach((stateObj) => { | ||
| const domain = computeStateDomain(stateObj); | ||
| for (const [entityId /*, stateObj */] of states) { |
Member
Author
There was a problem hiding this comment.
I am commenting out to show that this variable is available. We might need it in the future and I want people to not forget it .
bramkragten
approved these changes
Nov 23, 2018
| import { LocalizeFunc } from "../../../mixins/localize-base-mixin"; | ||
| import computeDomain from "../../../common/entity/compute_domain"; | ||
|
|
||
| interface CardConfig { |
Member
There was a problem hiding this comment.
We should use LovelaceConfig (Should be LovelaceCardConfig) and move the rest of the interfaces to types so it can be reused?
Member
Author
There was a problem hiding this comment.
In a new pr but yes. I didn't want to rename the other one , impacts so many files
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle groups that reference non-existing entities
Closes #2097