Hassio: Fix download snapshot#2071
Merged
balloob merged 6 commits intohome-assistant:devfrom Nov 21, 2018
bramkragten:hassio-snapshot-download
Merged
Hassio: Fix download snapshot#2071balloob merged 6 commits intohome-assistant:devfrom bramkragten:hassio-snapshot-download
balloob merged 6 commits intohome-assistant:devfrom
bramkragten:hassio-snapshot-download
Conversation
ghost
assigned
balloob
reviewed
Nov 21, 2018
| _computeDownloadName(snapshot) { | ||
| const name = this._computeName(snapshot).replace(/[^a-z0-9]+/gi, "_"); | ||
| return `Hass_io_${name}.tar`; | ||
| _downloadClicked() { |
balloob
reviewed
Nov 21, 2018
| return `Hass_io_${name}.tar`; | ||
| _downloadClicked() { | ||
| this.hass | ||
| .callWS({ |
Member
There was a problem hiding this comment.
We should make this a helper function in auth/data.ts (like the other functions in there)
balloob
approved these changes
Nov 21, 2018
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Few minor comments, ok to merge when addressed
balloob
reviewed
Nov 21, 2018
balloob
approved these changes
Nov 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the new
auth/sign_pathto generate a temp path.