Convert hui-input-select-entity-row to TypeScript/LitElement#2048
Merged
balloob merged 5 commits intohome-assistant:devfrom Nov 20, 2018
Merged
Convert hui-input-select-entity-row to TypeScript/LitElement#2048balloob merged 5 commits intohome-assistant:devfrom
balloob merged 5 commits intohome-assistant:devfrom
Conversation
ghost
assigned
balloob
reviewed
Nov 18, 2018
| (option) => | ||
| html` | ||
| <paper-item | ||
| @click="${() => this._selectedChanged(option as string)}" |
Member
There was a problem hiding this comment.
Don't do this. Instead mimic how the old component behaved: observing selected-item-label (as seen by it using {…} which indicates 2 way databinding). You can do this by listening to the selected-item-label-changed event on <paper-dropdown-menu> like the original did. Don't attach individual listeners to each item.
Member
Author
There was a problem hiding this comment.
Hopefully I didn't botch that too much with the commit I just pushed (it works) :) I was pretty unsure of what I was doing with this listener.
balloob
reviewed
Nov 18, 2018
balloob
approved these changes
Nov 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.