Skip to content

Add clearing of checked items to shopping-list-card#2034

Merged
balloob merged 1 commit intohome-assistant:devfrom
iantrich:shopping-clear
Nov 10, 2018
Merged

Add clearing of checked items to shopping-list-card#2034
balloob merged 1 commit intohome-assistant:devfrom
iantrich:shopping-clear

Conversation

@iantrich
Copy link
Copy Markdown
Member

@iantrich iantrich commented Nov 9, 2018

I debated with making the icon color the same as the section label color. Thoughts?

shopping-list

@ghost ghost assigned iantrich Nov 9, 2018
@ghost ghost added the in progress label Nov 9, 2018
@zsarnett
Copy link
Copy Markdown
Contributor

zsarnett commented Nov 9, 2018

Checked Items title is not showing on the demo page

@iantrich
Copy link
Copy Markdown
Member Author

iantrich commented Nov 9, 2018

Checked Items title is not showing on the demo page

@zsarnett the translation isn't available in the dev gallery, it looks like. I seem to recall @balloob mentioning this before. Perhaps the script/develop_gallery is missing something?

@balloob
Copy link
Copy Markdown
Member

balloob commented Nov 10, 2018

It requires a round trip -> merged to master -> uploaded to lokalise -> downloaded from lokalise and merged into master.

@balloob
Copy link
Copy Markdown
Member

balloob commented Nov 10, 2018

Oh, I guess someone should update our script to run based off dev, not master: #2037

@balloob balloob merged commit efbd97f into home-assistant:dev Nov 10, 2018
@ghost ghost removed the in progress label Nov 10, 2018
@iantrich iantrich deleted the shopping-clear branch November 16, 2018 19:17
@heitjer
Copy link
Copy Markdown

heitjer commented Jul 6, 2020

Is there any way to disable the "clear all" button?

@bramkragten
Copy link
Copy Markdown
Member

bramkragten commented Jul 6, 2020

Please don't comment on old closed PR's or issues, you can ask help at the community: https://www.home-assistant.io/help/

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants