Fix android hold action

[thomasloven]

This could possibly fix #1950.

I don't have an android device with chrome, so I can't test, but this prevents the context menu from popping up when emulating a touch device in chrome on my computer - which I think was the problem.

It would be great if someone could test this before merging.
@zsarnett ?

[zsarnett]

Will test as soon as I can

[zsarnett]

@thomasloven So it works when I inspect it in chrome debugger and click using my mouse.

But pressing the button on my phone using my finger I never get the purple circle and no matter how long I hold it never does the hold_action.

Also, not sure if this was an issue before but now when I try to scroll on the button it acts like I press the button (scroll on the button means I touch the button and pull up or down) this doesnt move the screen at all and only toggles and hold action doesnt work

Edit: Just reverted the changes and scrolling on the button does work with out this change

[thomasloven]

Well... back to the drawing board...

[thomasloven]

Next attempt. Could you go here, click and long-press each of the squares and then tell me what happens?

[zsarnett]

Holding

Tap

[zsarnett]

I don't know enough about this code and touch events to be able to review the code to say its "good" for merging. But It does work. Requesting @balloob to review

[zsarnett]

Tested: Hold and Tap Action work. Scrolling also works

[thomasloven]

The problem, for reference, was that chrome for android opens a context menu when pressing and holding for about half a second. When the context menu is opened, the touch event is interrupted, so no touchend is sent. Instead a touchcancel is sent, and for some reason this happens even if there is no context menu...

[casey-hill]

I'm not sure if this thread is still going on but the problem is interesting. I was able to use this thread to solve my own problem. While the fix is in place for the phones, a Windows 10 devices running Edge or Chrome isn't working using the toggle action. No idea how to troubleshoot something like this but my phone works fine … yet the computer(s) do not.

[thomasloven]

Avoid discussion in closed PRs.
If it's still not working for you with the lastest version of Home Assistant, please open a new issue.