Add checked item section to shopping-list-card#2005
Merged
balloob merged 8 commits intohome-assistant:devfrom Nov 9, 2018
Merged
Add checked item section to shopping-list-card#2005balloob merged 8 commits intohome-assistant:devfrom
balloob merged 8 commits intohome-assistant:devfrom
Conversation
ghost
assigned
zsarnett
reviewed
Nov 7, 2018
balloob
reviewed
Nov 7, 2018
Member
|
The reason localize doesn't work is because you override the |
2 tasks
Member
|
Documentation: home-assistant/home-assistant.io#7346 |
balloob
reviewed
Nov 7, 2018
balloob
approved these changes
Nov 8, 2018
balloob
reviewed
Nov 8, 2018
zsarnett
reviewed
Nov 8, 2018
| } | ||
| ` | ||
| ) | ||
| : html`` |
zsarnett
reviewed
Nov 8, 2018
| } | ||
| } | ||
|
|
||
| private _completeItem(ev): void { |
zsarnett
reviewed
Nov 8, 2018
| ); | ||
| } | ||
|
|
||
| private _saveEdit(ev): void { |
Member
Author
There was a problem hiding this comment.
ech. I don't know how to handle this. It's a MouseEvent...but the target is then a paper-checkbox type with an additional field itemId that I added...
Member
Author
There was a problem hiding this comment.
actually _saveEdit would be a KeyboardEvent or a MouseEvent...but only applies when you either click out or hit enter...I don't know what to do...
Contributor
|
Also need to rebase. Or resolve Merge Conflicts |
* Not getting value back from `this.localize`? at line 109
iantrich
force-pushed
the
shopping-checked
branch
from
8e1ae73 to
0799f70
Compare
balloob
approved these changes
Nov 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.