Skip to content

Revert RTL PR #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Nov 3, 2018
Merged

Revert RTL PR #1975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
857d705
Revert RTL PR
zsarnett Nov 3, 2018
3b95de6
Missed this change
zsarnett Nov 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions src/layouts/home-assistant-main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ class HomeAssistantMain extends NavigateMixin(EventsMixin(PolymerElement)) {
/* remove the grey tap highlights in iOS on the fullscreen touch targets */
-webkit-tap-highlight-color: rgba(0,0,0,0);
}
:host([rtl]) {
direction: rtl;
}
iron-pages, ha-sidebar {
/* allow a light tap highlight on the actual interface elements */
-webkit-tap-highlight-color: rgba(0,0,0,0.1);
Expand All @@ -45,7 +42,7 @@ class HomeAssistantMain extends NavigateMixin(EventsMixin(PolymerElement)) {
</iron-media-query>

<app-drawer-layout fullbleed="" force-narrow="[[computeForceNarrow(narrow, dockedSidebar)]]" responsive-width="0">
<app-drawer align="start" id="drawer" slot="drawer" disable-swipe="[[_computeDisableSwipe(hass)]]" swipe-open="[[!_computeDisableSwipe(hass)]]" persistent="[[dockedSidebar]]">
<app-drawer id="drawer" slot="drawer" disable-swipe="[[_computeDisableSwipe(hass)]]" swipe-open="[[!_computeDisableSwipe(hass)]]" persistent="[[dockedSidebar]]">
<ha-sidebar narrow="[[narrow]]" hass="[[hass]]" default-page="[[_defaultPage]]"></ha-sidebar>
</app-drawer>

Expand All @@ -72,11 +69,6 @@ class HomeAssistantMain extends NavigateMixin(EventsMixin(PolymerElement)) {
type: Boolean,
computed: "computeDockedSidebar(hass)",
},
rtl: {
type: Boolean,
reflectToAttribute: true,
computed: "computeRTL(hass)",
},
};
}

Expand Down Expand Up @@ -131,13 +123,6 @@ class HomeAssistantMain extends NavigateMixin(EventsMixin(PolymerElement)) {
return hass.dockedSidebar;
}

computeRTL(hass) {
return (
hass.translationMetadata.translations[hass.selectedLanguage].isRTL ||
false
);
}

_computeDisableSwipe(hass) {
return NON_SWIPABLE_PANELS.indexOf(hass.panelUrl) !== -1;
}
Expand Down
3 changes: 1 addition & 2 deletions src/translations/translationMetadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@
"nativeName": "Schwiizerdütsch"
},
"he": {
"nativeName": "עברית",
"isRTL": true
"nativeName": "עברית"
},
"hi": {
"nativeName": "हिन्दी"
Expand Down
1 change: 0 additions & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ export interface Panel {

export interface Translation {
nativeName: string;
isRTL: boolean;
fingerprints: { [fragment: string]: string };
}

Expand Down