Fix incompatible object/array property types (2 of 3) #19482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Supervisor
steverep
commented
Jan 20, 2024
| @property({ type: Array, attribute: "include-device-classes" }) | ||
| public includeDeviceClasses?: string[]; | ||
|
|
||
| @property({ attribute: "picked-device-label" }) |
There was a problem hiding this comment.
This is also clearly a bug fix, but I didn't see an issue for it
bramkragten
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes another third of the property type incompatibilities. I'm also disabling attributes for any function properties that should also fail the rule but don't (runem/lit-analyzer#350).
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: