Add getElementConfig to Glance + Add Form UI for updating YAML #1944
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| import { html, LitElement, PropertyDeclarations } from "@polymer/lit-element"; | ||
|
zsarnett marked this conversation as resolved.
|
||
| import "@polymer/paper-checkbox/paper-checkbox.js"; | ||
|
|
||
| import processConfigEntities from "../common/process-config-entities"; | ||
| import { hassLocalizeLitMixin } from "../../../mixins/lit-localize-mixin"; | ||
| import { HomeAssistant } from "../../../types.js"; | ||
| import { LovelaceCardEditor } from "../types.js"; | ||
| import { fireEvent } from "../../../common/dom/fire_event.js"; | ||
| import { Config, EntityConfig } from "../cards/hui-glance-card"; | ||
|
|
||
| import "../../../components/entity/state-badge.js"; | ||
| import "../../../components/entity/ha-entity-picker"; | ||
| import "../../../components/ha-card.js"; | ||
| import "../../../components/ha-icon.js"; | ||
| import { TemplateResult } from "lit-html"; | ||
|
zsarnett marked this conversation as resolved.
Outdated
|
||
|
|
||
| export class HuiGlanceCardEditor extends hassLocalizeLitMixin(LitElement) | ||
| implements LovelaceCardEditor { | ||
| public hass?: HomeAssistant; | ||
| private _config?: Config; | ||
| private _configEntities?: EntityConfig[]; | ||
|
|
||
| static get properties(): PropertyDeclarations { | ||
| return { | ||
| hass: {}, | ||
| _config: {}, | ||
| }; | ||
| } | ||
|
|
||
| public setConfig(config: Config): void { | ||
| this._config = config; | ||
| const entities = processConfigEntities(config.entities); | ||
|
|
||
| this._configEntities = entities; | ||
| } | ||
|
|
||
| protected render(): TemplateResult { | ||
| if (!this._config || !this.hass) { | ||
|
zsarnett marked this conversation as resolved.
Outdated
|
||
| return html``; | ||
| } | ||
|
|
||
| return html` | ||
| <paper-input | ||
| id="title" | ||
| @value-changed="${this._valueChanged}" | ||
| label="Title" | ||
| value="${this._config.title}" | ||
| ></paper-input> | ||
| ${this._configEntities!.map((entityConf) => | ||
| this.renderEntity(entityConf) | ||
| )}<br> | ||
| <paper-checkbox | ||
| id="show_name" | ||
| @change="${this._valueChanged}" | ||
| ?checked="${this._config.show_name !== false}" | ||
| >Show Entity's Name?</paper-checkbox><br><br> | ||
| <paper-checkbox | ||
| id="show_state" | ||
| @change="${this._valueChanged}" | ||
| ?checked="${this._config.show_state !== false}" | ||
| >Show Entity's State Text?</paper-checkbox><br> | ||
| `; | ||
| } | ||
|
|
||
| private renderEntity(entityConf: EntityConfig): TemplateResult { | ||
| return html` | ||
| <ha-entity-picker | ||
| hass="${this.hass}" | ||
| value="${entityConf.entity || entityConf}" | ||
| allow-custom-entity | ||
| ></ha-entity-picker> | ||
| `; | ||
| } | ||
|
|
||
| private _valueChanged(ev: MouseEvent): void { | ||
| if (!this._config || !this.hass) { | ||
| return; | ||
| } | ||
|
|
||
| const target = ev.target! as any; | ||
|
|
||
| const newValue = | ||
| target.checked !== undefined ? target.checked : target.value; | ||
|
|
||
| // Unsure why I could not grab a propery value ".configValue='show_name'" and ev.target.configValue wasnt working | ||
| this._config[target.id] = newValue; | ||
|
zsarnett marked this conversation as resolved.
Outdated
|
||
|
|
||
| fireEvent(this, "config-changed", { | ||
| config: this._config, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| "hui-glance-card-editor": HuiGlanceCardEditor; | ||
| } | ||
| } | ||
|
|
||
| customElements.define("hui-glance-card-editor", HuiGlanceCardEditor); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a future note; these cleanups should be done in a separate PR. Each time I review this PR (and it's been a few times!), I see all these changes that are actually just noise of the actual code/features.