Remove .js imports from src dir#1941
Closed
iantrich wants to merge 2 commits intohome-assistant:devfrom
Closed
Conversation
ghost
assigned
iantrich
commented
Nov 1, 2018
| workbox.routing.registerRoute( | ||
| new RegExp( | ||
| `${location.host}/(service_worker.js|service_worker_es5.js|manifest.json)` | ||
| `${location.host}/(service_worker|service_worker_es5|manifest.json)` |
Member
There was a problem hiding this comment.
Yeah we should only remove the extension from imports.
iantrich
commented
Nov 1, 2018
| </div> | ||
| <% if (!latestBuild) { %> | ||
| <script src="/static/custom-elements-es5-adapter.js"></script> | ||
| <script src="/static/custom-elements-es5-adapter"></script> |
Member
Author
There was a problem hiding this comment.
I'm not sure about these .template file modifications I made either. Things seem to run fine in my testing...?
Member
There was a problem hiding this comment.
Yeah revert them.
When you tested locally, did you navigate to the es5 version of authorize ?
balloob
reviewed
Nov 1, 2018
| @@ -1,5 +1,5 @@ | |||
| const serviceWorkerUrl = | |||
| __BUILD__ === "latest" ? "/service_worker.js" : "/service_worker_es5.js"; | |||
Member
There was a problem hiding this comment.
These should be reverted. Only ones that are used in either import or import(…), as those are resolved by webpack. Others are resolved by the browser and that won't work.
Member
Author
|
Going to scale this back to just lovelace to start in a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.