Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing imports (1 of 2) #19363

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix missing imports (1 of 2) #19363

merged 1 commit into from
Jan 15, 2024

Conversation

steverep
Copy link
Member

Proposed change

Fixes about half of the 57 missing import errors from lit-analyzer. Sorted imports in files modified, and removed an unused import from valve control.

We need a rule for no-unused-imports too 🤷🏻‍♂️

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added Supervisor Related to the supervisor panel Design Related to Home Assistant design gallery labels Jan 11, 2024
@steverep steverep added the needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview label Jan 11, 2024
bramkragten
bramkragten previously approved these changes Jan 11, 2024
@steverep
Copy link
Member Author

runem/lit-analyzer#348

@bramkragten bramkragten merged commit 920df03 into dev Jan 15, 2024
13 checks passed
@bramkragten bramkragten deleted the fix-missing-imports-1 branch January 15, 2024 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Design Related to Home Assistant design gallery needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants