-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Convert cover-row to TypeScript/LitElement #1933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
956afe1
Convert cover-row to TypeScript/LitElement
iantrich e51ef00
Extract `supports` methods from cover model
iantrich 3566d92
Address review comments
iantrich 4dc3c05
Revert line endings mixup
iantrich bf48518
Address review comments
iantrich 4722c23
Address review comments: error-row not working
iantrich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| import { html, LitElement, PropertyDeclarations } from "@polymer/lit-element"; | ||
| import { TemplateResult } from "lit-html"; | ||
|
|
||
| import "../components/hui-generic-entity-row.js"; | ||
| import "../../../components/ha-cover-controls.js"; | ||
| import "../../../components/ha-cover-tilt-controls.js"; | ||
|
|
||
| import { isTiltOnly } from "../../../util/cover-model.js"; | ||
| import { HomeAssistant } from "../../../types.js"; | ||
| import { EntityRow, EntityConfig } from "./types.js"; | ||
|
|
||
| class HuiCoverEntityRow extends LitElement implements EntityRow { | ||
| public hass?: HomeAssistant; | ||
| private _config?: EntityConfig; | ||
|
|
||
| static get properties(): PropertyDeclarations { | ||
| return { | ||
| hass: {}, | ||
| _config: {}, | ||
| }; | ||
| } | ||
|
|
||
| public setConfig(config: EntityConfig): void { | ||
| if (!config) { | ||
| throw new Error("Configuration error"); | ||
| } | ||
| this._config = config; | ||
| } | ||
|
|
||
| protected render(): TemplateResult { | ||
| if (!this._config || !this.hass) { | ||
| return html``; | ||
| } | ||
|
|
||
| const stateObj = this.hass.states[this._config.entity]; | ||
|
|
||
| if (!stateObj) { | ||
| return html` | ||
| <hui-error-entity-row | ||
| .entity=${this._config.entity} | ||
| ></hui-error-entity-row>`; | ||
| } | ||
|
|
||
| return html` | ||
| ${this.renderStyle()} | ||
| <hui-generic-entity-row | ||
| .hass=${this.hass} | ||
| .config=${this._config} | ||
| > | ||
| ${ | ||
| isTiltOnly(stateObj) | ||
| ? html` | ||
| <ha-cover-tilt-controls | ||
| .hass=${this.hass} | ||
| .stateObj=${stateObj} | ||
| ></ha-cover-tilt-controls>` | ||
| : html` | ||
| <ha-cover-controls | ||
| .hass=${this.hass} | ||
| .stateObj=${stateObj} | ||
| ></ha-cover-controls>` | ||
| } | ||
| </hui-generic-entity-row> | ||
| `; | ||
| } | ||
|
|
||
| private renderStyle(): TemplateResult { | ||
| return html` | ||
| <style> | ||
| ha-cover-controls, | ||
| ha-cover-tilt-controls { | ||
| margin-right: -.57em; | ||
| } | ||
| </style> | ||
| `; | ||
| } | ||
| } | ||
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| "hui-cover-entity-row": HuiCoverEntityRow; | ||
| } | ||
| } | ||
|
|
||
| customElements.define("hui-cover-entity-row", HuiCoverEntityRow); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.