Disable XSS filter in flow step description markdown#1599
Merged
balloob merged 1 commit intohome-assistant:masterfrom Aug 26, 2018
Merged
Disable XSS filter in flow step description markdown#1599balloob merged 1 commit intohome-assistant:masterfrom
balloob merged 1 commit intohome-assistant:masterfrom
Conversation
4 tasks
Member
|
Actually, I had a change of mind. It's too easy for people to update translations and this could be used as an attack vector. Looking at the We should instead add an option to |
Member
|
Ah, found even better, we can use this: That way we don't base 64 encode. I'll just white list this type. |
Member
|
Was working on something but didn't finish in time. won't have time until later tonight |
Contributor
Author
|
This PR has been replaced by #1600. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XSS filter will filter out
data:imagein<image>srcattribute. Disable the XSS filter allow us to use embedded image in description placeholder. Since we are fully control the step description placeholder, the XSS will not be the concern.See: home-assistant/core#16129 (comment)