Update state-card and more-info card to support new methods.#1532
Merged
balloob merged 3 commits intohome-assistant:masterfrom Aug 3, 2018
cnrd:vacuum-start-pause-refactor
Merged
Update state-card and more-info card to support new methods.#1532balloob merged 3 commits intohome-assistant:masterfrom cnrd:vacuum-start-pause-refactor
balloob merged 3 commits intohome-assistant:masterfrom
cnrd:vacuum-start-pause-refactor
Conversation
ghost
added
the
Merged
3 tasks
balloob
reviewed
Aug 3, 2018
| <paper-icon-button icon="hass:play-pause" on-click="onPlayPause" title="Start/Pause"></paper-icon-button> | ||
| </div> | ||
| <template is="dom-if" if="[[supportsStart(stateObj)]]"> | ||
| <div hidden$="[[!supportsStart(stateObj)]]"> |
Member
There was a problem hiding this comment.
Why have this hidden attribute if you're already inside a dom-if checking for the opposite?
balloob
approved these changes
Aug 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the vacuum state card and more-info card to support the new start and pause methods.
Backend changes: home-assistant/core#15751
Part of: home-assistant/architecture#29