Support for timestamp sensors in time trigger automation UI#15292
Merged
Conversation
piitaya
reviewed
Feb 1, 2023
Member
|
It will be easier if we can use inside selector {
entity: {
filter: [
{ domain: "input_datetime" },
{ domain: "sensor", device_class: "timestamp" },
]
}
} |
Co-authored-by: Paul Bottein <paul.bottein@gmail.com>
9 tasks
Member
Author
|
I'll put a hold on this until #15302 is done. |
Member
Author
|
Updated to use the new entity filter options. |
piitaya
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
In the automation editor for time trigger, the entity selector currently only populates with entities of domain input_datetime. The time trigger also supports entities of domain sensor, if those entities have a device_class of timestamp.
This change adds the sensors with device_class: timestamp to the entity selector.
A similar change is probably warranted in the time condition form as well. I will request approval for this code before duplicating it into the time condition as well.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: