Added change password card to profile panel.#1464
Added change password card to profile panel.#1464balloob merged 3 commits intohome-assistant:masterfrom
Conversation
ghost
added
the
| required | ||
| auto-validate | ||
| error-message='Required' | ||
| ></paper-input> |
There was a problem hiding this comment.
We should ask user input new password twice, or allow user unmask the password, likes
| import '../../resources/ha-style.js'; | ||
| import EventsMixin from '../../mixins/events-mixin.js'; | ||
|
|
||
| let registeredDialog = false; |
There was a problem hiding this comment.
I don't think it needs to be a dialog. Just a card on this page. It should still be its own component
| }, | ||
|
|
||
| _currentPassword: String, | ||
| _newPassword: String, |
There was a problem hiding this comment.
We should also include a type password again box and confirm in JavaScript that they are the same
There was a problem hiding this comment.
So instead of a button to unmask the password?
There was a problem hiding this comment.
Let's not do an unmask button, that is more a login experience thing. I would just have 2 inputs: _newPassword1 and _newPassword2
There was a problem hiding this comment.
Okay, so no current password verification? Or keep that too?
There was a problem hiding this comment.
Keep the current password verification.
| this.fire('show-change-password', { | ||
| hass: this.hass, | ||
| dialogClosedCallback: async () => { | ||
| this.fire('reload-users'); |
There was a problem hiding this comment.
This is a user management only event. Once password changed successfully, just a message above the form will do: Password successfully changed!
|
Also make sure to include a screenshot of how it looks in your PR description. |
jeradM
changed the title
jeradM
changed the title
|
Please also add translation strings for this PR to we can start translate... |
4 participants
Backend PR: home-assistant/core#15527