Separate row entity elements for Lovelace by c727 · Pull Request #1461 · home-assistant/frontend

c727 · 2018-07-17T14:47:48Z

    cards:
      - type: entities
        entities:
          - scene.romantic_lights
          - entity: device_tracker.demo_paulus
            secondary_info: entity-id
          - cover.kitchen_window
          - group.kitchen
          - lock.kitchen_door
          - entity: light.bed_light
            secondary_info: last-changed

fix: home-assistant/ui-schema#97
fix: home-assistant/ui-schema#69

balloob · 2018-07-17T17:40:24Z

 import fireEvent from '../../../common/dom/fire_event.js';

-import stateCardType from '../../../common/entity/state_card_type.js';
+import '../entity-row-elements/hui-generic-entity-row-element.js';


I think that the folder name can just be entity-row.

balloob · 2018-07-17T17:41:56Z

I think this is great. Our current entity rows are too coupled between display on left side and controls on right side. We should be able to extract all the controls on the right side and make the left configurable. It's just things like input_select that might need an override. Which is fine.

balloob · 2018-07-17T17:42:15Z

It's also great as it allows to maybe just override the controls instead of the full entity row with a custom web component.

balloob · 2018-07-17T22:27:54Z

Since you're making a generic row, consider use slot to fill in control

balloob · 2018-07-18T07:20:47Z

      const element = createEntityRowElement(entity, this.hass);
-      if (entityId && !DOMAINS_HIDE_MORE_INFO.includes(computeDomain(entityId))) {
-        element.classList.add('state-card-dialog');
-        element.addEventListener('click', () => this.fire('hass-more-info', { entityId }));


We should keep this here. We don't know where EntityRow will be used.

Although, I do really like if we only attach click listener to the left part of the generic row. Interacting with controls should never open more info.

balloob · 2018-07-18T07:32:31Z

  }

-  element.stateObj = stateObj;
  element.hass = hass;


Do we still need this or can we start removing hass from this file ? (as it should be)

balloob · 2018-07-18T07:52:06Z

+          color: var(--secondary-text-color);
+        }
+      </style>
+      <template is="dom-if" if="[[_stateObj]]">


If we hide everything when there is no stateObj, can we instead show a light yellow div saying "State X not found"?

balloob · 2018-07-18T07:54:16Z

+  }
+
+  _computeStateObj(states, entityId) {
+    return states && entityId && entityId in states ? states[entityId] : null;


No need to check entityId, config is invalid and this component should not be instantiated with it?

balloob · 2018-07-18T07:55:46Z

+  static get template() {
+    return html`
+      <style>
+        paper-button {


I don't see paper-button in this component

balloob · 2018-07-18T07:56:32Z

+          hass="[[hass]]"
+          config="[[_config]]"
+        >
+        <paper-input no-label-float=


remove " at end

balloob · 2018-07-18T07:57:10Z

+class HuiInputTextEntityRow extends PolymerElement {
+  static get template() {
+    return html`
+      <template is="dom-if" if="[[_stateObj]]">


Really not a fan of these guards for stateObj :(

balloob · 2018-07-18T07:59:16Z

+          margin: 0;
+        }
+      </style>
+      <template is="dom-if" if="[[_stateObj]]">


Not needed, already is in hui-generic-entity-row.

balloob · 2018-07-18T08:02:31Z

+          margin: 0;
+        }
+      </style>
+      <template is="dom-if" if="[[_stateObj]]">


Already in hui-generic-entity-row

balloob · 2018-07-18T08:03:16Z

+          hass="[[hass]]"
+          config="[[_config]]"
+        >
+          <div>


Why wrap it in div?

I need an element for my flexbox

balloob · 2018-07-18T08:03:28Z

+class HuiTextEntityRow extends PolymerElement {
+  static get template() {
+    return html`
+      <template is="dom-if" if="[[_stateObj]]">


Done inside hui-generic-entity-row

balloob · 2018-07-18T08:04:06Z

+    this._config = config;
+  }
+
+  getCardSize() {


are we trying to keep the same API between cards and entity rows?

hups I thought we use it also here, removed it

balloob · 2018-07-18T08:04:46Z

+class HuiToggleEntityRow extends PolymerElement {
+  static get template() {
+    return html`
+      <template is="dom-if" if="[[_stateObj]]">


Done inside hui-generic-entity-row

balloob · 2018-07-18T08:06:31Z

+    <state-info
+      hass="[[hass]]"
+      state-obj="[[stateObj]]"
+      in-dialog="[[inDialog]]"


In retrospect, in-dialog is such a misnomer as attribute for state-info. It defines context instead of behavior (show-last-changed) while state info should not know anything about dialogs. Oh well, so we learn

balloob · 2018-07-18T08:07:02Z

This is already looking very good !

randellhodges · 2018-09-12T14:56:39Z

This merge removed the overrideName changes that was added on July 1. Was that on purpose, or an oversight? I'm attempting to create a state card in lovelace and want to pass along the name from the entity card configuration but I have no way to pass it into state-info since this property has been removed.

See the bottom of the diff:
8c44e24#diff-cc39ce33639eea793f68fa0b9315237f

balloob · 2018-09-13T07:21:16Z

No discussion in merged PRs.

Separate row entity elements for Lovelace

36f2658

homeassistant added the cla-signed label Jul 17, 2018

ghost assigned c727 Jul 17, 2018

ghost added the in progress label Jul 17, 2018

balloob reviewed Jul 17, 2018

View reviewed changes

Update

0a9dd98

homeassistant added the cla-signed label Jul 17, 2018

c727 added 3 commits July 18, 2018 04:31

Update

0a904fb

Add fan

212d231

Add support for last changed

ea5b394

balloob reviewed Jul 18, 2018

View reviewed changes

c727 added 2 commits July 18, 2018 13:51

Feedback

2142efb

Feedback2

9a1d133

c727 added 2 commits July 18, 2018 15:20

Update

ff59c6d

Update

5619220

c727 mentioned this pull request Jul 18, 2018

Lovelace: Add secondary info docs for entities card home-assistant/home-assistant.io#5816

Merged

2 tasks

Fix timer

23bd39b

ghost assigned balloob Jul 18, 2018

Update

2c8ac05

homeassistant added the cla-signed label Jul 18, 2018

Lint

dfef546

balloob changed the title ~~WIP: Separate row entity elements for Lovelace~~ Separate row entity elements for Lovelace Jul 18, 2018

balloob merged commit 8c44e24 into master Jul 18, 2018

ghost removed the in progress label Jul 18, 2018

balloob deleted the separate-row-entity-elements branch July 18, 2018 15:25

home-assistant locked as resolved and limited conversation to collaborators Sep 13, 2018

Conversation

c727 commented Jul 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balloob commented Jul 17, 2018

Uh oh!

balloob commented Jul 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balloob commented Jul 17, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balloob commented Jul 18, 2018

Uh oh!

randellhodges commented Sep 12, 2018

Uh oh!

balloob commented Sep 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

c727 commented Jul 17, 2018 •

edited

Loading

balloob commented Jul 17, 2018 •

edited

Loading