Merged
Conversation
3 tasks
Contributor
|
(didn't actually look at the code) |
Member
Author
|
Because we're creating a user/password that will be used to login to Home Assistant. The created user will be an owner account, able to create other users that can log in. |
awarecan
reviewed
Jul 16, 2018
src/onboarding/ha-onboarding.js
Outdated
| <div class="layout vertical center fit"> | ||
| <img src="/static/icons/favicon-192x192.png" height="192"> | ||
|
|
||
| <p>Create your user account.</p> |
Contributor
There was a problem hiding this comment.
We need warn user they cannot change password after creation, at least for now
Member
Author
There was a problem hiding this comment.
Fixed. Updated screenshot in description.
c727
reviewed
Jul 17, 2018
src/onboarding/ha-onboarding.js
Outdated
| <div class="layout vertical center fit"> | ||
| <img src="/static/icons/favicon-192x192.png" height="192"> | ||
|
|
||
| <p>Create your user account.</p> |
Contributor
There was a problem hiding this comment.
Is this view for the admin/owner account only? Maybe we should mention it then
Member
Author
There was a problem hiding this comment.
Yes, this view is only shown once during initial setup of Home Assisatant. Think of it like setting up a new Windows or MacOS installation.
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an onboarding flow. Onboarding flow is automatically triggered on first install. It is triggered by the backend by redirecting all normal pages to the onboarding page. Once finished, the onboarding page will redirect to the main page to start auth.
Depends on backend PR home-assistant/core#15492
It's ugly, it's simple and it's just a start 👍 We will add more steps (like setting instance name/location, doing initial discovery/config entries).