Skip to content

Lovelace: add basic support for badges#1443

Merged
balloob merged 6 commits into
masterfrom
love-badges
Jul 13, 2018
Merged

Lovelace: add basic support for badges#1443
balloob merged 6 commits into
masterfrom
love-badges

Conversation

@c727
Copy link
Copy Markdown
Contributor

@c727 c727 commented Jul 12, 2018 

views:
  - title: Overview
    badges:
      - switch.decorative_lights
      - light.ceiling_lights
      - lock.front_door
      - binary_sensor.movement_backyard
      - binary_sensor.basement_floor_wet
    cards:  []

@ghost ghost assigned c727 Jul 12, 2018
@ghost ghost added the in progress label Jul 12, 2018
balloob
balloob reviewed Jul 13, 2018
View reviewed changes
Comment thread src/panels/lovelace/hui-view.js
}

#badges {
margin: 8px 16px;

This comment was marked as resolved.

Sign in to view

balloob
balloob reviewed Jul 13, 2018
View reviewed changes
Comment thread src/panels/lovelace/hui-view.js
}

if (!config || !config.badges || !Array.isArray(config.badges)) {
this._badges = [];
Copy link
Copy Markdown
Member

@balloob balloob Jul 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also set CSS display property of this.$.badges to hidden.

balloob
balloob approved these changes Jul 13, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge when comments addressed

@ghost ghost assigned balloob Jul 13, 2018
@balloob balloob merged commit c11cf53 into master Jul 13, 2018
@ghost ghost removed the in progress label Jul 13, 2018
@balloob balloob deleted the love-badges branch July 13, 2018 11:42
@c727 c727 mentioned this pull request Jul 13, 2018
Merged
2 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

Assignees

@balloob balloob

@c727 c727

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c727 @balloob @homeassistant