Skip to content

Picture elements: add service-icon#1439

Merged
c727 merged 5 commits into
masterfrom
love-pe-servive-icon
Jul 12, 2018
Merged

Picture elements: add service-icon#1439
c727 merged 5 commits into
masterfrom
love-pe-servive-icon

Conversation

@c727
Copy link
Copy Markdown
Contributor

@c727 c727 commented Jul 12, 2018

fix: home-assistant/ui-schema#91

  - title: Picture elements
    cards:
      - type: picture-elements
        image: https://images.pexels.com/photos/316465/pexels-photo-316465.jpeg?auto=compress&cs=tinysrgb&dpr=2&h=750&w=1260
        elements:
          - type: service-icon
            icon: mdi:power
            title: Ligth off
            service: light.turn_off
            service_data:
              entity_id: light.ceiling_lights

@ghost ghost assigned c727 Jul 12, 2018
@ghost ghost added the in progress label Jul 12, 2018
balloob
balloob reviewed Jul 12, 2018
View reviewed changes
Comment thread src/panels/lovelace/cards/hui-picture-elements-card.js Outdated
import computeStateDisplay from '../../../common/entity/compute_state_display.js';
import computeStateName from '../../../common/entity/compute_state_name.js';

import callService from '../common/call-service.js';
Copy link
Copy Markdown
Member

@balloob balloob Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this helper, can you use the new click handler that was just merged seconds ago.

balloob
balloob approved these changes Jul 12, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge when migrated to use new click handler.

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Jul 12, 2018

I changed the toggle types to use - instead of _ to match our other types and the docs. cc: @jeradM

@c727 c727 merged commit 6a35fc9 into master Jul 12, 2018
@ghost ghost removed the in progress label Jul 12, 2018
@c727 c727 deleted the love-pe-servive-icon branch July 12, 2018 10:34
@c727 c727 mentioned this pull request Jul 15, 2018
Merged
2 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

Assignees

@c727 c727

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c727 @balloob @homeassistant