Skip to content

RTL updates #12745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zsarnett merged 2 commits into from
May 24, 2022
Merged

RTL updates #12745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e9d9e6
RTL updates
yosilevy May 21, 2022
4246a83
Fix review
yosilevy May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/ha-chip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,13 @@ export class HaChip extends LitElement {
line-height: 14px;
color: var(--ha-chip-icon-color, var(--ha-chip-text-color));
}
.mdc-chip.mdc-chip--selected .mdc-chip__checkmark,
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the .no-text right?

Copy link
Copy Markdown
Contributor Author

@yosilevy yosilevy May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed it

.mdc-chip.no-text
.mdc-chip__icon--leading:not(.mdc-chip__icon--leading-hidden) {
margin-right: -4px;
margin-inline-start: -4px;
margin-inline-end: 4px;
direction: var(--direction);
}

span[role="gridcell"] {
Expand Down
3 changes: 3 additions & 0 deletions src/components/ha-textfield.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ export class HaTextField extends TextFieldBase {
.mdc-text-field__affix--suffix {
padding-left: var(--text-field-suffix-padding-left, 12px);
padding-right: var(--text-field-suffix-padding-right, 0px);
padding-inline-start: var(--text-field-suffix-padding-left, 12px);
padding-inline-end: var(--text-field-suffix-padding-right, 0px);
direction: var(--direction);
}

.mdc-text-field:not(.mdc-text-field--disabled)
Expand Down
2 changes: 2 additions & 0 deletions src/panels/config/application_credentials/ha-config-application-credentials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ export class HaConfigApplicationCredentials extends LitElement {
.selected-txt {
font-weight: bold;
padding-left: 16px;
padding-inline-start: 16px;
direction: var(--direction);
}
.table-header .selected-txt {
margin-top: 20px;
Expand Down
2 changes: 2 additions & 0 deletions src/panels/config/devices/ha-config-device-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,6 +1178,8 @@ export class HaConfigDevicePage extends LitElement {
display: flex;
align-items: center;
padding-left: 8px;
padding-inline-start: 8px;
direction: var(--direction);
}

.column,
Expand Down
2 changes: 2 additions & 0 deletions src/panels/config/devices/ha-config-devices-dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,9 @@ export class HaConfigDeviceDashboard extends LitElement {
.clear {
color: var(--primary-color);
padding-left: 8px;
padding-inline-start: 8px;
text-transform: uppercase;
direction: var(--direction);
}
`,
haStyle,
Expand Down
6 changes: 6 additions & 0 deletions src/panels/config/entities/ha-config-entities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,6 +976,8 @@ export class HaConfigEntities extends SubscribeMixin(LitElement) {
.selected-txt {
font-weight: bold;
padding-left: 16px;
padding-inline-start: 16px;
direction: var(--direction);
}
.table-header .selected-txt {
margin-top: 20px;
Expand All @@ -985,6 +987,8 @@ export class HaConfigEntities extends SubscribeMixin(LitElement) {
}
.header-toolbar .header-btns {
margin-right: -12px;
margin-inline-end: -12px;
direction: var(--direction);
}
.header-btns {
display: flex;
Expand All @@ -999,7 +1003,9 @@ export class HaConfigEntities extends SubscribeMixin(LitElement) {
.clear {
color: var(--primary-color);
padding-left: 8px;
padding-inline-start: 8px;
text-transform: uppercase;
direction: var(--direction);
}
`,
];
Expand Down
2 changes: 1 addition & 1 deletion src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class HaConfigLovelaceDashboards extends LitElement {
${dashboard.default
? html`
<ha-svg-icon
style="padding-left: 10px;"
style="padding-left: 10px; padding-inline-start: 10px; direction: var(--direction);"
.path=${mdiCheckCircleOutline}
></ha-svg-icon>
<paper-tooltip animation-delay="0">
Expand Down
2 changes: 2 additions & 0 deletions src/panels/energy/ha-panel-energy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ class PanelEnergy extends LitElement {
hui-energy-period-selector {
width: 100%;
padding-left: 16px;
padding-inline-start: 16px;
--disabled-text-color: rgba(var(--rgb-text-primary-color), 0.5);
direction: var(--direction);
}
`,
];
Expand Down
2 changes: 2 additions & 0 deletions src/panels/lovelace/cards/hui-calendar-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ export class HuiCalendarCard extends LitElement implements LovelaceCard {
line-height: 1.2;
padding-top: 16px;
padding-left: 8px;
padding-inline-start: 8px;
direction: var(--direction);
}
`;
}
Expand Down
6 changes: 6 additions & 0 deletions src/panels/lovelace/cards/hui-shopping-list-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,16 +372,22 @@ class HuiShoppingListCard

.addButton {
padding-right: 16px;
padding-inline-end: 16px;
cursor: pointer;
direction: var(--direction);
}

.reorderButton {
padding-left: 16px;
padding-inline-start: 16px;
cursor: pointer;
direction: var(--direction);
}

ha-checkbox {
margin-left: -12px;
margin-inline-start: -12px;
direction: var(--direction);
}

ha-textfield {
Expand Down
2 changes: 2 additions & 0 deletions src/panels/lovelace/components/hui-energy-period-selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,8 @@ export class HuiEnergyPeriodSelector extends SubscribeMixin(LitElement) {
}
ha-button-toggle-group {
padding-left: 8px;
padding-inline-start: 8px;
direction: var(--direction);
}
mwc-button {
flex-shrink: 0;
Expand Down
2 changes: 2 additions & 0 deletions src/panels/lovelace/editor/config-elements/hui-map-card-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ export class HuiMapCardEditor extends LitElement implements LovelaceCardEditor {
css`
.geo_location_sources {
padding-left: 20px;
padding-inline-start: 20px;
direction: var(--direction);
}
`,
];
Expand Down
2 changes: 2 additions & 0 deletions src/panels/lovelace/hui-root.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,8 +946,10 @@ class HUIRoot extends LitElement {
.edit-icon {
color: var(--accent-color);
padding-left: 8px;
padding-inline-start: 8px;
vertical-align: middle;
--mdc-theme-text-disabled-on-light: var(--disabled-text-color);
direction: var(--direction);
}
.edit-icon.view {
display: none;
Expand Down