Skip to content

Get attributes from first state when using minimal responses #12732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
May 20, 2022
Merged

Get attributes from first state when using minimal responses #12732

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ae09f2
Get attributes from first state when using minimal responses
bdraco May 19, 2022
38f92b8
one more place
bdraco May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/data/history.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ const processTimelineEntity = (
states: EntityHistoryState[]
): TimelineEntity => {
const data: TimelineState[] = [];
const last: EntityHistoryState = states[states.length - 1];
const first: EntityHistoryState = states[0];
for (const state of states) {
if (data.length > 0 && state.s === data[data.length - 1].state) {
continue;
Expand All @@ -282,7 +282,7 @@ const processTimelineEntity = (
localize,
language,
entityId,
state.a || last.a,
state.a || first.a,
state.s
),
state: state.s,
Expand All @@ -307,7 +307,7 @@ const processLineChartEntities = (

Object.keys(entities).forEach((entityId) => {
const states = entities[entityId];
const last: EntityHistoryState = states[states.length - 1];
const first: EntityHistoryState = states[0];
const domain = computeDomain(entityId);
const processedStates: LineChartState[] = [];

Expand Down Expand Up @@ -352,7 +352,7 @@ const processLineChartEntities = (

data.push({
domain,
name: computeStateNameFromEntityAttributes(entityId, last.a),
name: computeStateNameFromEntityAttributes(entityId, first.a),
entity_id: entityId,
states: processedStates,
});
Expand Down