Skip to content

Generate Hass and Hass.io specific iconset#1214

Merged
balloob merged 7 commits intomasterfrom
hass-icons
May 27, 2018
Merged

Generate Hass and Hass.io specific iconset#1214
balloob merged 7 commits intomasterfrom
hass-icons

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 27, 2018

This replaces #1100.

Generate iconsets for Hass and Hass.io based on the icons in use. This reduces the initial icon load from 855K (276K gzip) to 53K (18K gzip)! If an mdi icon is referenced, we will load the MDI iconset on demand.

Backend PR: home-assistant/core#14185

@balloob balloob merged commit 66012da into master May 27, 2018
@balloob balloob deleted the hass-icons branch May 27, 2018 21:04
@knd775
Copy link
Copy Markdown

knd775 commented Jun 11, 2018

If a user references mdi in their config, they will still download mdi in it's entirety, correct? So this will only save bandwidth/loading time if a user has no mdi icons?

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Jun 11, 2018

Correct.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jun 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants